Re: [PATCH 3/3] add: use advise_if_enabled for ADVICE_ADD_EMBEDDED_REPO

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 29, 2024, 19:31 UTC
Message-ID: <xmqqjzlkygvh.fsf@gitster.g>
In-Reply-To: <de916779-3c0c-4cf0-b78e-d0536c65af0e@gmail.com>

Rubén Justo <rjusto@gmail.com> writes:

Show 5 quoted lines

>> This one also needs a similar justification, but with a twist.
>
> May I ask what you would find a good justification?
>
> Perhaps "newer" -> "now preferred"?

That is merely shifting justification around. You'd now need to answer: Why do you consider it preferred?

A few obvious advantages of using if_enabled() form are:

 - you do not have to give "here is how to disable this piece of advice"
   yourself.

 - the code can become shorter.

and they may make it preferred to use it, when appropriate.

> Good point about the naming.  I'm not so sure about the "only once"
> part, but I do not have any strong objection.

I am not sure what you are not sure about ;-).

If you are adding a test for a feature because it is not covered by existing tests, and if that feature consists of two parts, it is naturally expected of you to cover both parts with the new test, unless there is a strong reason not to. No?

I would understand if you said because of such and such reasons, we should not cover the "two instances of violation, only one advice" half of the feature, though.