Re: [PATCH 3/3] add: use advise_if_enabled for ADVICE_ADD_EMBEDDED_REPO

From: Rubén Justo <rjusto@gmail.com>
Date: Mar 29, 2024, 19:59 UTC
Message-ID: <a76a0935-78e6-4ad3-9bf9-989f5ed53b84@gmail.com>
In-Reply-To: <xmqqjzlkygvh.fsf@gitster.g>

On Fri, Mar 29, 2024 at 12:31:30PM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> Rubén Justo <rjusto@gmail.com> writes:
> 
> >> This one also needs a similar justification, but with a twist.
> >
> > May I ask what you would find a good justification?
> >
> > Perhaps "newer" -> "now preferred"?
> 
> That is merely shifting justification around.  You'd now need to
> answer: Why do you consider it preferred?

Because it's newer ;-D

Maybe I'll point to the commit where advise_if_enabled() was introduced, b3b18d1621 (advice: revamp advise API, 2020-03-02). We have some arguments there. I'll sleep on it.