git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] add: use advise_if_enabled

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 29, 2024, 17:28 UTC
Message-ID
<xmqq1q7t0wxp.fsf@gitster.g>
In-Reply-To
<06c9b422-b22e-4310-ad5b-1686616ab860@gmail.com>
Rubén Justo <rjusto@gmail.com> writes:
> This series is a simple change, in builtin/add.c, from:
>
> 	if (advice_enabled(XXX))
> 		advise(MMM)

I wonder if a coccinelle rule can automatically identify and rewrite these ...

>
> to the newer:
>
> 	advise_if_enabled(XXX, MMM)
... to this form automatically.
Previous: Rubén JustoNext: Rubén Justo
Message 12 of 17 in “add: use advise_if_enabled”
  1. 0/3 add: use advise_if_enabledRubén Justo, Mar 29, 2024
  2. 1/3 add: use advise_if_enabled for ADVICE_ADD_IGNORED_FILERubén Justo, Mar 29, 2024
  3. Junio C HamanoMar 29, 2024
  4. 2/3 add: use advise_if_enabled for ADVICE_ADD_EMPTY_PATHSPECRubén Justo, Mar 29, 2024
  5. 3/3 add: use advise_if_enabled for ADVICE_ADD_EMBEDDED_REPORubén Justo, Mar 29, 2024
  6. Junio C HamanoMar 29, 2024
  7. Rubén JustoMar 29, 2024
  8. Junio C HamanoMar 29, 2024
  9. Rubén JustoMar 29, 2024
  10. Junio C HamanoMar 29, 2024
  11. Rubén JustoMar 30, 2024
  12. Junio C HamanoMar 29, 2024
  13. Rubén JustoMar 29, 2024
  14. 0/3 add: use advise_if_enabledRubén Justo, Mar 30, 2024
  15. 1/3 add: use advise_if_enabled for ADVICE_ADD_IGNORED_FILERubén Justo, Mar 30, 2024
  16. 2/3 add: use advise_if_enabled for ADVICE_ADD_EMPTY_PATHSPECRubén Justo, Mar 30, 2024
  17. 3/3 add: use advise_if_enabled for ADVICE_ADD_EMBEDDED_REPORubén Justo, Mar 30, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.