Re: [PATCH v3 0/5] Encode submodule gitdir names to avoid conflicts

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 7, 2025, 17:27 UTC
Message-ID: <xmqqjz16k4gr.fsf@gitster.g>
In-Reply-To: <xmqq5xcqn2pe.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 8 quoted lines

> Adrian Ratiu <adrian.ratiu@collabora.com> writes:
>
>> Currently any existing submodule gitdir names are left untouched 
>> and are used as-is (unencoded) after the extension is enabled.
>
> And in order to make sure that a funny names and paths in existing
> submodules that can be misinterpreted as encoded would be registered
> with the new submodule.<name>.gitdirpath variable?

Sorry but this is -ECANNOTPARSE; let me try again.

    An existing submodule's gitdir may look like an encoded one (it may
    be littered with %xx if urlencode is what you chose), but we do not
    want it to be misinterpreted as such.  One way to ensure that the
    gitdir of the submodule <name> is literally that path is to use
    submodule.<name>.gitdirpath to point at the directory, right?

> That would be a robust way to transition.