Re: [PATCH v7 04/11] submodule: introduce extensions.submodulePathConfig
- From
Adrian Ratiu <adrian.ratiu@collabora.com>
- Date
- Dec 23, 2025, 13:35 UTC
- Message-ID
- <87y0mtwcbc.fsf@gentoo.mail-host-address-is-not-set>
- In-Reply-To
- <xmqqy0mwsedz.fsf@gitster.g>
On Sun, 21 Dec 2025, Junio C Hamano <gitster@pobox.com> wrote:
Show 22 quoted lines
> Adrian Ratiu <adrian.ratiu@collabora.com> writes: > > This comment is not about the primary contents of this series, but > I notice that the whitespace immediately after "errors like" is not > a SP but a HT here. > >> +* Encounter errors like `refusing to create ... in another submodule's git dir` > 123456701234567012345670 > > I have already alluded to it as a #leftoverbit in a different topic, > but we probably want to have a new whitespace error class to detect > a HT in the middle of a sentence that should have been a SP. > > Perhaps the rule would be something like a HT that is at the column > that is at (tab-width - 1) modulo tab-width (default 8, but the > usual attribute applies), that is surrounded by non-whitespace > characters on both sides. > > I may be counting off-by-one, though ;-) The quoted problematic line > has, labeling the leftmost column as 1, the HT at the 24th column. > > cf. https://lore.kernel.org/git/xmqq5xa76z0o.fsf@gitster.g/
I think the algorithm you pointed out is sound, seems to work, so I sent a separate patch for it:
https://public-inbox.org/git/20251223132756.604036-1-adrian.ratiu@collabora.com/T/#u
Will fix the whitespace in this series on the next re-roll.
Thanks!