Re: [PATCH 3/9] submodule: add gitdir path config override
- From
Adrian Ratiu <adrian.ratiu@collabora.com>
- Date
- Aug 21, 2025, 13:05 UTC
- Message-ID
- <87y0rc7rl1.fsf@collabora.com>
- In-Reply-To
- <km4qhwxpmwld2qw4ihmzjtk7o5yeblfhhm6hqsh4nmzdbkdyyc@mwqb7a76liop>
On Wed, 20 Aug 2025, Josh Steadmon <steadmon@google.com> wrote:
Show 18 quoted lines
> On 2025.08.17 00:36, Adrian Ratiu wrote: >> This adds an ability to override gitdir paths via config files >> (not .gitmodules), such that any encoding scheme can be changed >> and JGit & co don't need to exactly match the default encoding. >> A new test and a helper are added. The helper will be used by >> further tests exercising gitdir paths & encodings. >> Based-on-patch-by: Brandon Williams <bmwill@google.com> >> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com> --- >> builtin/submodule--helper.c | 17 +++++++++++++++++ >> submodule.c | 11 +++++++++++ >> t/lib-verify-submodule-gitdir-path.sh | 15 +++++++++++++++ >> t/t7400-submodule-basic.sh | 15 +++++++++++++++ 4 >> files changed, 58 insertions(+) create mode 100644 >> t/lib-verify-submodule-gitdir-path.sh > > Sorry to keep sending piecemeal feedback. You should also > document the new config option in > `Documentation/config/submodule.adoc`
No problem, thank you for taking the time to review & give feedback.
Will do in v2.