git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] format-patch: fix leak of rev_info in prepare_bases()

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 3, 2026, 20:45 UTC
Message-ID
<xmqqjyrbhkf8.fsf@gitster.g>
In-Reply-To
<akY4u02vdBkVqs7m@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 8 quoted lines
>> Likewise I find the dual clang/gcc jobs to be overkill. Compiling with
>> both is useful, as they have different warnings. But have we ever seen a
>> case where running the tests showed a different result with different
>> compilers?
>
> Not that I'd know of. As you say, I think it makes sense to use
> different compilers in general. But I don't really think we need to have
> this as a full "compiler x tests" matrix.

Very true. Different configurations with TEST-vars are great combination to test, but we are not in the business of hunting bugs in clang/gcc so we long as they compile (instead of warning "hey, that construct gives you undefined behaviour"), we shouldn't have to run the test suite with the same configuration for both.

> I'm certainly on board with reducing the test matrix a bit. I'm sure
> that we can have a cleverer selection of jobs where we both have the
> same test coverage as we have right now while running less jobs overall.

Yeah, and if we can spend the saved cycles for better coverage, that would be grat.

Previous: Patrick SteinhardtNext: Jeff King
Message 11 of 15 in “small leak fix in format-patch”
  1. 0/2 small leak fix in format-patchJeff King, Jun 30, 2026
  2. 1/2 t: move LSan errors from stdout to stderrJeff King, Jun 30, 2026
  3. 2/2 format-patch: fix leak of rev_info in prepare_bases()Jeff King, Jun 30, 2026
  4. Patrick SteinhardtJun 30, 2026
  5. Jeff KingJul 1, 2026
  6. Patrick SteinhardtJul 1, 2026
  7. Jeff KingJul 1, 2026
  8. Patrick SteinhardtJul 1, 2026
  9. Jeff KingJul 2, 2026
  10. Patrick SteinhardtJul 2, 2026
  11. Junio C HamanoJul 3, 2026
  12. Jeff KingJul 6, 2026
  13. Patrick SteinhardtJul 6, 2026
  14. Karthik NayakJul 4, 2026
  15. Jeff KingJul 6, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.