git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] t: move LSan errors from stdout to stderr

From
Jeff King <peff@peff.net>
Date
Jun 30, 2026, 06:41 UTC
Message-ID
<20260630064159.GA3733961@coredump.intra.peff.net>
In-Reply-To
<20260630063944.GA3733670@coredump.intra.peff.net>

When we find LSan errors, we dump them via "say_color", which goes to stdout. This is mostly harmless, since stdout and stderr tend to go to the same place (either the user's terminal, or to the ".out" file with --verbose-log).

But when running under a TAP harness like prove, they are split and stdout is interpreted as TAP output. Historically even this was fine, as the extra lines on stdout would be ignored. But since 389c83025d (t: let prove fail when parsing invalid TAP output, 2026-06-04) we instruct the TAP reader to complain, and a leaking test will result in complaints like this (this is a real leak which we have yet to fix):

  $ GIT_TEST_COMMIT_GRAPH=1 make SANITIZE=leak test
  [...]
  Test Summary Report
  -------------------
  t4014-format-patch.sh (Wstat: 256 (exited 1) Tests: 226 Failed: 30)
    Failed tests:  197-226
    Non-zero exit status: 1
    Parse errors: Unknown TAP token: ""
                  Unknown TAP token: "================================================================="
                  Unknown TAP token: "==git==3693658==ERROR: LeakSanitizer: detected memory leaks"
                  Unknown TAP token: ""
                  Unknown TAP token: "Direct leak of 200 byte(s) in 1 object(s) allocated from:"
  Displayed the first 5 of 1531 TAP syntax errors.
  Re-run prove with the -p option to see them all.

You still see the failing tests, so it's mostly just an annoyance. We can fix it by redirecting to stderr (actually descriptor 4, which is our verbose-respecting variant). I confirmed manually that the output still appears with --verbose-log, and even with a single-test "-i --verbose-only=197" going to the terminal.

Signed-off-by: Jeff King <peff@peff.net>
---
 t/test-lib.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index ceefb99bff..d390c53ec1 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -1217,14 +1217,14 @@ check_test_results_san_file_ () {
 	then
 		return
 	fi &&
-	say_color error "$(cat "$TEST_RESULTS_SAN_FILE".*)" &&
+	say_color >&4 error "$(cat "$TEST_RESULTS_SAN_FILE".*)" &&
 
 	if test "$test_failure" = 0
 	then
-		say "Our logs revealed a memory leak, exit non-zero!" &&
+		say >&4 "Our logs revealed a memory leak, exit non-zero!" &&
 		invert_exit_code=t
 	else
-		say "Our logs revealed a memory leak..."
+		say >&4 "Our logs revealed a memory leak..."
 	fi
 }
 
-- 
2.55.0.346.g83d0ea82e4
Previous: Jeff KingNext: Jeff King
Message 2 of 15 in “small leak fix in format-patch”
  1. 0/2 small leak fix in format-patchJeff King, Jun 30, 2026
  2. 1/2 t: move LSan errors from stdout to stderrJeff King, Jun 30, 2026
  3. 2/2 format-patch: fix leak of rev_info in prepare_bases()Jeff King, Jun 30, 2026
  4. Patrick SteinhardtJun 30, 2026
  5. Jeff KingJul 1, 2026
  6. Patrick SteinhardtJul 1, 2026
  7. Jeff KingJul 1, 2026
  8. Patrick SteinhardtJul 1, 2026
  9. Jeff KingJul 2, 2026
  10. Patrick SteinhardtJul 2, 2026
  11. Junio C HamanoJul 3, 2026
  12. Jeff KingJul 6, 2026
  13. Patrick SteinhardtJul 6, 2026
  14. Karthik NayakJul 4, 2026
  15. Jeff KingJul 6, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.