git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] format-patch: fix leak of rev_info in prepare_bases()

From
Patrick Steinhardt <ps@pks.im>
Date
Jul 1, 2026, 09:01 UTC
Message-ID
<akTXYoY7mSQUM33P@pks.im>
In-Reply-To
<20260701084733.GA814472@coredump.intra.peff.net>
On Wed, Jul 01, 2026 at 04:47:33AM -0400, Jeff King wrote:
Show 19 quoted lines
> On Wed, Jul 01, 2026 at 10:42:38AM +0200, Patrick Steinhardt wrote:
> 
> > > We already run a special leak job for linux-reftables. Why not turn that
> > > job into "leaks plus reftables plus test-vars"? The only downside would
> > > be potentially hiding leaks found by linux-reftables-leaks if the
> > > test-vars features force us into a difference code path. But looking at
> > > the list, it doesn't seem likely to me. None of them is particularly
> > > ref-related.
> > > 
> > > In fact, I kind of wonder if we could fold linux-reftables into the
> > > test-vars job completely.
> > 
> > linux-reftable or linux-reftable-leaks? I think it would certainly make
> > sense to drop one of these and merge it into linux-TEST-vars. The
> > linux-reftable job doesn't provide any benefit over its -leak variant,
> > so that would be the candidate I'd personally merge.
> 
> Both. Fold linux-reftable into linux-TEST-vars, and then drop
> linux-reftable-leaks in favor of a new linux-TEST-vars-leaks.

Hm, okay. I guess that should be fine. Do we also want to do a similar thing for macOS and create a macos-TEST-vars job that exercises all of this?

Also, while at it... I really think that job name is just plain awful. While at it, we might rename it to something more sensible like "linux-changed-defaults".

Patrick
Previous: Jeff KingNext: Jeff King
Message 8 of 15 in “small leak fix in format-patch”
  1. 0/2 small leak fix in format-patchJeff King, Jun 30, 2026
  2. 1/2 t: move LSan errors from stdout to stderrJeff King, Jun 30, 2026
  3. 2/2 format-patch: fix leak of rev_info in prepare_bases()Jeff King, Jun 30, 2026
  4. Patrick SteinhardtJun 30, 2026
  5. Jeff KingJul 1, 2026
  6. Patrick SteinhardtJul 1, 2026
  7. Jeff KingJul 1, 2026
  8. Patrick SteinhardtJul 1, 2026
  9. Jeff KingJul 2, 2026
  10. Patrick SteinhardtJul 2, 2026
  11. Junio C HamanoJul 3, 2026
  12. Jeff KingJul 6, 2026
  13. Patrick SteinhardtJul 6, 2026
  14. Karthik NayakJul 4, 2026
  15. Jeff KingJul 6, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.