Re: [PATCH] Documentation/technical/api-hashmap: Remove source highlighting

From: Junio C Hamano <gitster@pobox.com>
Date: May 20, 2014, 17:31 UTC
Message-ID: <xmqqiop01hn2.fsf@gitster.dls.corp.google.com>
In-Reply-To: <alpine.DEB.2.02.1405191839230.44324@all-night-tool.MIT.EDU>

Anders Kaseorg <andersk@MIT.EDU> writes:

Show 15 quoted lines

>> How bad does the documentation look with the patch applied (I know how 
>> bad it looks without source-highlight installed)?  If it is not too bad, 
>> then it sounds like a sensible solution to drop the highlight markup 
>> unconditionally like the patch that started this thread does, taking the 
>> "common denominator" approach.  You seem to agree, and I do not object, 
>> either.
>
> Original version with syntax-highlight installed (pretty):
> http://web.mit.edu/andersk/Public/api-hashmap/old-highlight.html
>
> Original version with syntax-highlight missing (corrupted):
> http://web.mit.edu/andersk/Public/api-hashmap/old-no-highlight.html
>
> Patched version (boring but readable):
> http://web.mit.edu/andersk/Public/api-hashmap/patched.html

Thanks. I've queued the patch for v2.0 and the comparison between the first and the third clearly shows that it is the right thing to do ;-).