git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Documentation/technical/api-hashmap: Remove source highlighting

From
Jeremiah Mahler <jmmahler@gmail.com>
Date
May 17, 2014, 15:22 UTC
Message-ID
<20140517152219.GA31912@hudson.localdomain>
In-Reply-To
<alpine.DEB.2.02.1405170707260.44324@all-night-tool.MIT.EDU>
On Sat, May 17, 2014 at 07:08:55AM -0400, Anders Kaseorg wrote:
Show 5 quoted lines
> The highlighting was pretty, but unfortunately, the failure mode when
> source-highlight is not installed was that the entire code block
> disappears.  See https://bugs.debian.org/745591,
> https://bugs.launchpad.net/bugs/1316810.
> 
I agree that a broken document is an unacceptable failure mode.

But I do not understand why 'source-highlight' is not an install requirement for 'git-doc'. If I install 'source-highlight' on my Debian machine the code looks great.

  apt-get install source-highlight

I also noticed that this seems to be the single place where source code highlighting is used in Documentation/technical. So it might be worthwhile to eliminate this dependency all together as Anders patch does.

-- 
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler
Previous: Anders KaseorgNext: Anders Kaseorg
Message 2 of 6 in “Documentation/technical/api-hashmap: Remove source highlighting”
  1. Documentation/technical/api-hashmap: Remove source highlightingAnders Kaseorg, May 17, 2014
  2. Jeremiah MahlerMay 17, 2014
  3. Anders KaseorgMay 18, 2014
  4. Junio C HamanoMay 19, 2014
  5. Anders KaseorgMay 19, 2014
  6. Junio C HamanoMay 20, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.