From: Junio C Hamano Date: Tue, 20 May 2014 17:31:29 GMT Subject: Re: [PATCH] Documentation/technical/api-hashmap: Remove source highlighting Message-ID: In-Reply-To: Anders Kaseorg writes: >> How bad does the documentation look with the patch applied (I know how >> bad it looks without source-highlight installed)? If it is not too bad, >> then it sounds like a sensible solution to drop the highlight markup >> unconditionally like the patch that started this thread does, taking the >> "common denominator" approach. You seem to agree, and I do not object, >> either. > > Original version with syntax-highlight installed (pretty): > http://web.mit.edu/andersk/Public/api-hashmap/old-highlight.html > > Original version with syntax-highlight missing (corrupted): > http://web.mit.edu/andersk/Public/api-hashmap/old-no-highlight.html > > Patched version (boring but readable): > http://web.mit.edu/andersk/Public/api-hashmap/patched.html Thanks. I've queued the patch for v2.0 and the comparison between the first and the third clearly shows that it is the right thing to do ;-).