Re: [PATCH v5 0/5] Improve guessing of repository names
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 10, 2015, 18:07 UTC
- Message-ID
- <xmqqio8nuiej.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1439221705-20336-1-git-send-email-ps@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 29 quoted lines
> This is version 5 of my patch series which aims to improve > guessed directory names in several cases. > > This version now includes the patches from Jeff which were > previously a separate patch series. Besides fixing behavior when > cloning a repository with trailing '.git' suffix they also add a > new test suite that verifies guessed directory names. I've > amended 'clone: add tests for output directory' to add additional > tests (as proposed by Junio). > > Changes to my own patches include improved commit messages > detailing why certain changes are done the way they are done and > a change to authentication-data-stripping, such that we now strip > greedily until the last '@' sign in the host part (proposed by > Junio, as well). > > Jeff King (2): > clone: add tests for output directory > clone: use computed length in guess_dir_name > > Patrick Steinhardt (3): > clone: do not include authentication data in guessed dir > clone: do not use port number as dir name > clone: abort if no dir name could be guessed > > builtin/clone.c | 65 +++++++++++++++++++++++++----- > t/t5603-clone-dirname.sh | 103 +++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 157 insertions(+), 11 deletions(-) > create mode 100755 t/t5603-clone-dirname.sh
Looks good.
I'll forge your sign-off for two patches from Peff and queue the whole thing.
Thanks.