git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 6/6] clone: add tests for cloning with empty path

From
Patrick Steinhardt <ps@pks.im>
Date
Aug 4, 2015, 11:29 UTC
Message-ID
<1438687797-14254-7-git-send-email-ps@pks.im>
In-Reply-To
<1438687797-14254-1-git-send-email-ps@pks.im>

Test behavior of `git clone` when working with an empty path component. This may be the case when cloning a file system's root directory or from a remote server's root.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 t/t1509-root-worktree.sh | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)
diff --git a/t/t1509-root-worktree.sh b/t/t1509-root-worktree.sh
index 553a3f6..d521ca3 100755
--- a/t/t1509-root-worktree.sh
+++ b/t/t1509-root-worktree.sh
@@ -237,6 +237,49 @@ test_foobar_foobar
 
 test_expect_success 'cleanup' 'rm -rf /.git'
 
+say "clone .git at root without reponame"
+
+test_expect_success 'go to /' 'cd /'
+test_expect_success 'setup' '
+	echo "Initialized empty Git repository in /.git/" > expected &&
+	git init > result &&
+	test_cmp expected result
+'
+
+test_clone_expect_dir() {
+	URL="$1"
+	DIR="$2"
+	cat <<-EOF >expected &&
+		Cloning into '$DIR'...
+		warning: You appear to have cloned an empty repository.
+		EOF
+	git clone "$URL" >result 2>&1 &&
+	rm -rf "$DIR" &&
+	test_cmp expected result
+}
+
+test_expect_success 'go to /clones' 'mkdir /clones && cd /clones'
+test_expect_success 'simple clone of /' '
+	cat <<-EOF >expected &&
+		fatal: No directory name could be guessed.
+		Please specify a directory on the command line
+		EOF
+	test_expect_code 128 git clone / >result 2>&1 &&
+	test_cmp expected result'
+
+test_expect_success 'clone with file://host/' '
+	test_clone_expect_dir file://127.0.0.1/ 127.0.0.1'
+test_expect_success 'clone with file://user@host/' '
+	test_clone_expect_dir file://user@127.0.0.1/ 127.0.0.1'
+test_expect_success 'clone with file://user:password@host/' '
+	test_clone_expect_dir file://user:password@127.0.0.1/ 127.0.0.1'
+test_expect_success 'clone with file://host:port/' '
+	test_clone_expect_dir file://127.0.0.1:9999/ 127.0.0.1'
+test_expect_success 'clone with file://user:password@host:port' '
+	test_clone_expect_dir file://user:password@127.0.0.1:9999/ 127.0.0.1'
+
+test_expect_success 'cleanup' 'rm -rf /.git /clones'
+
 say "auto bare gitdir"
 
 # DESTROYYYYY!!!!!
-- 
2.5.0
Previous: Patrick SteinhardtNext: Eric Sunshine
Message 30 of 53 in “clone: fix repo name when cloning a server's root”
  1. clone: fix repo name when cloning a server's rootPatrick Steinhardt, Jul 27, 2015
  2. Duy NguyenJul 27, 2015
  3. Patrick SteinhardtJul 27, 2015
  4. Junio C HamanoJul 27, 2015
  5. 0/6 clone: fix repo name when cloning a server's rootPatrick Steinhardt, Jul 29, 2015
  6. 1/6 tests: fix broken && chains in t1509-root-worktreePatrick Steinhardt, Jul 29, 2015
  7. 2/6 tests: fix cleanup after tests in t1509-root-worktreePatrick Steinhardt, Jul 29, 2015
  8. 3/6 connect: expose parse_connect_url()Patrick Steinhardt, Jul 29, 2015
  9. 4/6 connect: move error check to caller of parse_connect_urlPatrick Steinhardt, Jul 29, 2015
  10. Eric SunshineJul 29, 2015
  11. Patrick SteinhardtJul 30, 2015
  12. 5/6 clone: fix hostname parsing when guessing dirPatrick Steinhardt, Jul 29, 2015
  13. Junio C HamanoJul 29, 2015
  14. Patrick SteinhardtJul 30, 2015
  15. Junio C HamanoJul 30, 2015
  16. Junio C HamanoJul 30, 2015
  17. Patrick SteinhardtAug 3, 2015
  18. Jeff KingAug 3, 2015
  19. Junio C HamanoAug 3, 2015
  20. 6/6 clone: add tests for cloning with empty pathPatrick Steinhardt, Jul 29, 2015
  21. Eric SunshineJul 30, 2015
  22. Junio C HamanoJul 31, 2015
  23. Patrick SteinhardtJul 31, 2015
  24. 0/6 fix repo name when cloning a server's rootPatrick Steinhardt, Aug 4, 2015
  25. 1/6 tests: fix broken && chains in t1509-root-worktreePatrick Steinhardt, Aug 4, 2015
  26. 2/6 tests: fix cleanup after tests in t1509-root-worktreePatrick Steinhardt, Aug 4, 2015
  27. 3/6 clone: do not include authentication data in guessed dirPatrick Steinhardt, Aug 4, 2015
  28. 4/6 clone: do not use port number as dir namePatrick Steinhardt, Aug 4, 2015
  29. 5/6 clone: abort if no dir name could be guessedPatrick Steinhardt, Aug 4, 2015
  30. 6/6 clone: add tests for cloning with empty pathPatrick Steinhardt, Aug 4, 2015
  31. Eric SunshineAug 4, 2015
  32. Junio C HamanoAug 5, 2015
  33. Jeff KingAug 5, 2015
  34. Torsten BögershausenAug 6, 2015
  35. Junio C HamanoAug 6, 2015
  36. 0/3 fix repo name when cloning a server's rootPatrick Steinhardt, Aug 5, 2015
  37. 1/3 clone: do not include authentication data in guessed dirPatrick Steinhardt, Aug 5, 2015
  38. Junio C HamanoAug 5, 2015
  39. Junio C HamanoAug 5, 2015
  40. Junio C HamanoAug 5, 2015
  41. Patrick SteinhardtAug 6, 2015
  42. Junio C HamanoAug 7, 2015
  43. Patrick SteinhardtAug 8, 2015
  44. 2/3 clone: do not use port number as dir namePatrick Steinhardt, Aug 5, 2015
  45. 3/3 clone: abort if no dir name could be guessedPatrick Steinhardt, Aug 5, 2015
  46. Junio C HamanoAug 5, 2015
  47. 0/5 Improve guessing of repository namesPatrick Steinhardt, Aug 10, 2015
  48. 1/5 clone: add tests for output directoryPatrick Steinhardt, Aug 10, 2015
  49. 2/5 clone: use computed length in guess_dir_namePatrick Steinhardt, Aug 10, 2015
  50. 3/5 clone: do not include authentication data in guessed dirPatrick Steinhardt, Aug 10, 2015
  51. 4/5 clone: do not use port number as dir namePatrick Steinhardt, Aug 10, 2015
  52. 5/5 clone: abort if no dir name could be guessedPatrick Steinhardt, Aug 10, 2015
  53. Junio C HamanoAug 10, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.