git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/6] clone: fix repo name when cloning a server's root

From
Patrick Steinhardt <ps@pks.im>
Date
Jul 29, 2015, 15:51 UTC
Message-ID
<1438185076-28870-1-git-send-email-ps@pks.im>
In-Reply-To
<1437997708-10732-1-git-send-email-ps@pks.im>

As proposed the previous patch has been changed such that we now utilize parse_connect_url(), which splits a connect URL by host and path components. If the path component is empty we now try to fall back to the host component, stripping it of its port and authentication information.

The first two patches fix the t1509-root-worktree tests. They currently were not working due to broken &&-chains and are required to test cloning from /.

The next two patches expose parse_connect_url(), which is then used in the fifth patch. The last patch provides tests for the behavior. To keep it simple we just use file:// URIs, which have the option of including a host in there, e.g. file://127.0.0.1/foobar.

Patrick Steinhardt (6):
  tests: fix broken && chains in t1509-root-worktree
  tests: fix cleanup after tests in t1509-root-worktree
  connect: expose parse_connect_url()
  connect: move error check to caller of parse_connect_url
  clone: fix hostname parsing when guessing dir
  clone: add tests for cloning / without workdir name
 builtin/clone.c          | 73 +++++++++++++++++++++++++++++++++++-------------
 connect.c                | 19 +++----------
 connect.h                | 13 +++++++++
 t/t1509-root-worktree.sh | 43 +++++++++++++++++++++++++---
 4 files changed, 109 insertions(+), 39 deletions(-)
-- 
2.5.0
Previous: Junio C HamanoNext: Patrick Steinhardt
Message 5 of 53 in “clone: fix repo name when cloning a server's root”
  1. clone: fix repo name when cloning a server's rootPatrick Steinhardt, Jul 27, 2015
  2. Duy NguyenJul 27, 2015
  3. Patrick SteinhardtJul 27, 2015
  4. Junio C HamanoJul 27, 2015
  5. 0/6 clone: fix repo name when cloning a server's rootPatrick Steinhardt, Jul 29, 2015
  6. 1/6 tests: fix broken && chains in t1509-root-worktreePatrick Steinhardt, Jul 29, 2015
  7. 2/6 tests: fix cleanup after tests in t1509-root-worktreePatrick Steinhardt, Jul 29, 2015
  8. 3/6 connect: expose parse_connect_url()Patrick Steinhardt, Jul 29, 2015
  9. 4/6 connect: move error check to caller of parse_connect_urlPatrick Steinhardt, Jul 29, 2015
  10. Eric SunshineJul 29, 2015
  11. Patrick SteinhardtJul 30, 2015
  12. 5/6 clone: fix hostname parsing when guessing dirPatrick Steinhardt, Jul 29, 2015
  13. Junio C HamanoJul 29, 2015
  14. Patrick SteinhardtJul 30, 2015
  15. Junio C HamanoJul 30, 2015
  16. Junio C HamanoJul 30, 2015
  17. Patrick SteinhardtAug 3, 2015
  18. Jeff KingAug 3, 2015
  19. Junio C HamanoAug 3, 2015
  20. 6/6 clone: add tests for cloning with empty pathPatrick Steinhardt, Jul 29, 2015
  21. Eric SunshineJul 30, 2015
  22. Junio C HamanoJul 31, 2015
  23. Patrick SteinhardtJul 31, 2015
  24. 0/6 fix repo name when cloning a server's rootPatrick Steinhardt, Aug 4, 2015
  25. 1/6 tests: fix broken && chains in t1509-root-worktreePatrick Steinhardt, Aug 4, 2015
  26. 2/6 tests: fix cleanup after tests in t1509-root-worktreePatrick Steinhardt, Aug 4, 2015
  27. 3/6 clone: do not include authentication data in guessed dirPatrick Steinhardt, Aug 4, 2015
  28. 4/6 clone: do not use port number as dir namePatrick Steinhardt, Aug 4, 2015
  29. 5/6 clone: abort if no dir name could be guessedPatrick Steinhardt, Aug 4, 2015
  30. 6/6 clone: add tests for cloning with empty pathPatrick Steinhardt, Aug 4, 2015
  31. Eric SunshineAug 4, 2015
  32. Junio C HamanoAug 5, 2015
  33. Jeff KingAug 5, 2015
  34. Torsten BögershausenAug 6, 2015
  35. Junio C HamanoAug 6, 2015
  36. 0/3 fix repo name when cloning a server's rootPatrick Steinhardt, Aug 5, 2015
  37. 1/3 clone: do not include authentication data in guessed dirPatrick Steinhardt, Aug 5, 2015
  38. Junio C HamanoAug 5, 2015
  39. Junio C HamanoAug 5, 2015
  40. Junio C HamanoAug 5, 2015
  41. Patrick SteinhardtAug 6, 2015
  42. Junio C HamanoAug 7, 2015
  43. Patrick SteinhardtAug 8, 2015
  44. 2/3 clone: do not use port number as dir namePatrick Steinhardt, Aug 5, 2015
  45. 3/3 clone: abort if no dir name could be guessedPatrick Steinhardt, Aug 5, 2015
  46. Junio C HamanoAug 5, 2015
  47. 0/5 Improve guessing of repository namesPatrick Steinhardt, Aug 10, 2015
  48. 1/5 clone: add tests for output directoryPatrick Steinhardt, Aug 10, 2015
  49. 2/5 clone: use computed length in guess_dir_namePatrick Steinhardt, Aug 10, 2015
  50. 3/5 clone: do not include authentication data in guessed dirPatrick Steinhardt, Aug 10, 2015
  51. 4/5 clone: do not use port number as dir namePatrick Steinhardt, Aug 10, 2015
  52. 5/5 clone: abort if no dir name could be guessedPatrick Steinhardt, Aug 10, 2015
  53. Junio C HamanoAug 10, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.