Re: [PATCH 29/29] lock_ref_sha1_basic(): only handle REF_NODEREF mode
Michael Haggerty <mhagger@alum.mit.edu> writes:
Show 16 quoted lines
> Now lock_ref_sha1_basic() is only called with flags==REF_NODEREF. So we
> don't have to handle other cases anymore.
>
> This enables several simplifications, the most interesting of which come
> from the fact that ref_lock::orig_ref_name is now always the same as
> ref_lock::ref_name:
>
> * Remove ref_lock::orig_ref_name
> * Remove local variable orig_refname from lock_ref_sha1_basic()
> * commit_ref_update() never has to write to the reflog for
> lock->orig_ref_name
>
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---
> refs/files-backend.c | 54 ++++++++++++++++++++--------------------------------
> 1 file changed, 21 insertions(+), 33 deletions(-)
Finished reading the whole thing and it made quite a lot of sense.
Thanks.