[PATCH 04/29] refname_is_safe(): don't allow the empty string

From

Michael Haggerty <mhagger@alum.mit.edu>

Date

Apr 27, 2016, 16:57 UTC

Message-ID

<51574acf932c4650110d9f7be0601532879f624c.1461768689.git.mhagger@alum.mit.edu>

In-Reply-To

<cover.1461768689.git.mhagger@alum.mit.edu>

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
This fixes a coding error from the original implementation.

 refs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/refs.c b/refs.c
index 5789152..ca0280f 100644
--- a/refs.c
+++ b/refs.c
@@ -136,11 +136,12 @@ int refname_is_safe(const char *refname)
 		free(buf);
 		return result;
 	}
-	while (*refname) {
+
+	do {
 		if (!isupper(*refname) && *refname != '_')
 			return 0;
 		refname++;
-	}
+	} while (*refname);
 	return 1;
 }
 

-- 
2.8.1