Re: [PATCH 24/29] ref_transaction_update(): check refname_is_safe() at a minimum
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Apr 29, 2016, 07:42 UTC
- Message-ID
- <57231082.50806@alum.mit.edu>
- In-Reply-To
- <xmqqtwim95cm.fsf@gitster.mtv.corp.google.com>
On 04/27/2016 10:14 PM, Junio C Hamano wrote:
Show 9 quoted lines
> Michael Haggerty <mhagger@alum.mit.edu> writes: > >> If the user has asked that a new value be set for a reference, we use >> check_refname_format() to verify that the reference name satisfies all >> of the rules. But in other cases, at least check that refname_is_safe(). > > It isn't clear to me what "in other cases" exactly refers to. A > request to delete a ref would obviously one of those that do not > "ask that a new value be set", but are there other cases?
The other case is `verify`, which can be used to check the old value of a reference without modifying it. `verify` is exposed via `git update-ref --stdin`
Michael