Re: [PATCH v2 02/94] builtin/apply: avoid parameter shadowing 'p_value' global

From: Junio C Hamano <gitster@pobox.com>
Date: May 12, 2016, 19:09 UTC
Message-ID: <xmqqinyjf5zj.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160511131745.2914-3-chriscool@tuxfamily.org>

Christian Couder <christian.couder@gmail.com> writes:

Show 5 quoted lines

> Let's just rename the global 'state_p_value' as it will become
> 'state->p_value' in a following patch.
>
> This also avoid errors when compiling with -Wshadow and makes
> it safer to later move global variables into a "state" struct.

Looks correctly done (I looked at remaining instances of "p_value").

Will queue.  Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.