From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 12 May 2016 19:09:36 GMT
Subject: Re: [PATCH v2 02/94] builtin/apply: avoid parameter shadowing 'p_value' global
Message-ID: <xmqqinyjf5zj.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160511131745.2914-3-chriscool@tuxfamily.org>

Christian Couder <christian.couder@gmail.com> writes:

> Let's just rename the global 'state_p_value' as it will become
> 'state->p_value' in a following patch.
>
> This also avoid errors when compiling with -Wshadow and makes
> it safer to later move global variables into a "state" struct.

Looks correctly done (I looked at remaining instances of "p_value").

Will queue.  Thanks.