Re: [PATCH v2 54/94] builtin/apply: make parse_chunk() return a negative integer on error

From: Christian Couder <christian.couder@gmail.com>
Date: Jun 8, 2016, 15:14 UTC
Message-ID: <CAP8UFD0Fow4HEp65D3Vbf=J4OtdeqxHZFDnnUABuyYkDJ3iXyg@mail.gmail.com>
In-Reply-To: <CAPig+cQkKijp_Mg0Ho0wAFSxmLin0EPA_a5PwV9DaHkHLJKNMA@mail.gmail.com>

On Mon, May 16, 2016 at 5:04 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 11 quoted lines

> On Wed, May 11, 2016 at 9:17 AM, Christian Couder
> <christian.couder@gmail.com> wrote:
>> To libify `git apply` functionality we have to signal errors to the
>> caller instead of die()ing or exit()ing.
>>
>> To do that in a compatible manner with the rest of the error handling
>> in builtin/apply.c, find_header() should return -1 instead of calling
>> die() or exit().
>
> Why is this talking about making find_header() return -1? Didn't that
> happen in the previous patch?

Yeah, it should be parse_chunk() not find_header().

This is fixed in my current branch.

Thanks, Christian.