Re: [RFC/PATCH 0/2] git diff <(command1) <(command2)

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 11, 2016, 21:27 UTC
Message-ID: <xmqqinrt1zcx.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161111201958.2175-1-dennis@kaarsemaker.net>

Dennis Kaarsemaker <dennis@kaarsemaker.net> writes:

> No tests or documentation updates yet, and I'm not sure whether
> --follow-symlinks in other modes than --no-index should be supported, ignored
> (as it is now) or cause an error, but I'm leaning towards the third option.

My knee-jerk reaction is:

 * The --no-index mode should default to your --follow-symlinks
   behaviour, without any option to turn it on or off.

 * If normal "diff" that follows symlinks by default has an option
   to disable it, then it is OK to also add --no-follow-symlinks
   that is only valid in the --no-index mode, so that we can mimick
   it better (I do not think this is the case, though).

 * Other modes should not follow symbolic links ever, no need for a
   new option.

In any case, I'd advise you not to reroll this too quickly and frequently until the end of this cycle. During a feature freeze, I won't take new topics in 'pu' as that would add more things I need to worry about, and if you reroll in too quick succession, it will become harder to identify the latest set and queue after the release.

Thanks.