Re: [RFC/PATCH 0/2] git diff <(command1) <(command2)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 16, 2016, 09:50 UTC
Message-ID: <alpine.DEB.2.20.1611161039590.3746@virtualbox>
In-Reply-To: <xmqqtwb9wywp.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Mon, 14 Nov 2016, Junio C Hamano wrote:

Show 5 quoted lines

> I _think_ the no-index mode was primarily for those who want to use
> our diff as a replacement for GNU and other diffs, and from that
> point of view, I'd favour not doing the "comparing symbolic link?
> We'll show the difference between the link contents, not target"
> under no-index mode myself.

If I read this correctly, then we are in agreement that the default for --no-index should be as it is right now, i.e. comparing symlink targets as opposed to --follow-links.

> That is a lot closer to the diff other people implemented, not ours.
> Hence the knee-jerk reaction I gave in
> 
> http://public-inbox.org/git/xmqqinrt1zcx.fsf@gitster.mtv.corp.google.com

Let me quote the knee-jerk reaction:

> My knee-jerk reaction is:
>
>  * The --no-index mode should default to your --follow-symlinks
>    behaviour, without any option to turn it on or off.

But this is the exact opposite of what I find reasonable.

Ciao, Johannes