Re: [PATCH v2 1/4] sha1_file: fix hardcoded size in null_sha1

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 16, 2017, 19:46 UTC
Message-ID: <xmqqinhnjnxr.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <bc6dc9fd13dfb6539af994c662eebf2474e731fb.1502905085.git.patryk.obara@gmail.com>

Patryk Obara <patryk.obara@gmail.com> writes:

> This prevents compilation error if GIT_MAX_RAWSZ is different than 20.

The above made me scratch my head wondering why because it does not say what the root cause of the issue is. It would have avoided a few strand of lost hair if it were more like this, perhaps:

	The array is declared in cache.h as

	    extern const unsigned char null_sha1[GIT_MAX_RAWSZ];

	The definition of it we have in sha1_file.c must match.

Show 19 quoted lines

>
> Signed-off-by: Patryk Obara <patryk.obara@gmail.com>
> ---
>  sha1_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sha1_file.c b/sha1_file.c
> index b60ae15..f5b5bec 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -32,7 +32,7 @@
>  #define SZ_FMT PRIuMAX
>  static inline uintmax_t sz_fmt(size_t s) { return s; }
>  
> -const unsigned char null_sha1[20];
> +const unsigned char null_sha1[GIT_MAX_RAWSZ];
>  const struct object_id null_oid;
>  const struct object_id empty_tree_oid = {
>  	EMPTY_TREE_SHA1_BIN_LITERAL