Re: [PATCH 2/5] sha1_file: fix hardcoded size in null_sha1

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 15, 2017, 19:02 UTC
Message-ID: <xmqqbmngr6wq.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kaCA29j6ON4KSsB=EH8FPfZGE56hVGSAAepcPiH952v6g@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 8 quoted lines

> Once we have 2 hash functions usable in a local Git installation,
> this would be wasteful for the smaller hash function (and the
> related grafts).
>
> I think Jonathan once envisioned an 'optimized' version as a
> second step, maybe this is a good time to discuss how we'd
> get the right size for e.g. allocating memory, as _MAX_ seems
> to be not the correct solution long term?

MAX is inevitable only if we envision that we have to handle objects named using two or more hashing schemes at the same time, with the same binary and during the same run inside a single process.

Using MAX may be nicer even if we use only one hashing scheme at a time, though.