Re: [PATCH 3/5] commit: replace the raw buffer with strbuf in read_graft_line
- From
Patryk Obara <patryk.obara@gmail.com>
- Date
- Aug 16, 2017, 12:24 UTC
- Message-ID
- <CAJfL8+QreNvRqVZ0t1Sw=+o4nFK6WuvuOWix_C0MNFik6Cc+rA@mail.gmail.com>
- In-Reply-To
- <CAGZ79kaCtbuDEUJqJ+nVUW78ksLMyHZ2xhnbunUqzjkGRuYg+A@mail.gmail.com>
On Tue, Aug 15, 2017 at 7:02 PM, Stefan Beller <sbeller@google.com> wrote:
>> const int entry_size = GIT_SHA1_HEXSZ + 1; > > outside the scope of this patch: > Is GIT_SHA1_HEXSZ or GIT_MAX_HEXSZ the right call here?
I think neither one. In my opinion, this code should not be so closely coupled to hash parsing code - it should be tasked with parsing whitespace separated list of commit ids without relying on specific commit id length or format.
-- | ← Ceci n'est pas une pipe Patryk Obara