git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pthread.h: manually align parameter lists

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 11, 2019, 05:59 UTC
Message-ID
<xmqqimovhles.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<b3d6dfe44a76c4f3bf00eb901c1844b12300c66e.1570736137.git.liu.denton@gmail.com>
Denton Liu <liu.denton@gmail.com> writes:
Show 25 quoted lines
> In previous patches, extern was mechanically removed from function
> declarations without care to formatting, causing parameter lists to be
> misaligned. Manually format changed sections such that the parameter
> lists are realigned.
>
> Viewing this patch with 'git diff -w' should produce no output.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
> I missed a step in 'dl/compat-cleanup'. This patch can be applied on the
> tip of that branch.
>
>  compat/win32/pthread.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
> index f1cfe73de9..737983d00b 100644
> --- a/compat/win32/pthread.h
> +++ b/compat/win32/pthread.h
> @@ -51,7 +51,7 @@ typedef struct {
>  } pthread_t;
>  
>  int pthread_create(pthread_t *thread, const void *unused,
> -			  void *(*start_routine)(void*), void *arg);
> +		   void *(*start_routine)(void*), void *arg);
Yup, I missed that too.  Thanks for a clean-up.
>  
>  /*
>   * To avoid the need of copying a struct, we use small macro wrapper to pass
Previous: Denton Liu
Message 2 of 2 in “pthread.h: manually align parameter lists”
  1. pthread.h: manually align parameter listsDenton Liu, Oct 10, 2019
  2. Junio C HamanoOct 11, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.