threads / patch / 52014

patchpthread.h: manually align parameter lists

Subject: [PATCH] pthread.h: manually align parameter lists

## tl;dr

2 messages between Oct 10, 2019 and Oct 11, 2019. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Denton Liu· Oct 10, 2019, 19:37 UTC · lore

In previous patches, extern was mechanically removed from function declarations without care to formatting, causing parameter lists to be misaligned. Manually format changed sections such that the parameter lists are realigned.

Viewing this patch with 'git diff -w' should produce no output.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
I missed a step in 'dl/compat-cleanup'. This patch can be applied on the
tip of that branch.

 compat/win32/pthread.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to compat/win32/pthread.h +1 −1

diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
index f1cfe73de9..737983d00b 100644
--- a/compat/win32/pthread.h
+++ b/compat/win32/pthread.h
@@ -51,7 +51,7 @@ typedef struct {
 } pthread_t;
 
 int pthread_create(pthread_t *thread, const void *unused,
-			  void *(*start_routine)(void*), void *arg);
+		   void *(*start_routine)(void*), void *arg);
 
 /*
  * To avoid the need of copying a struct, we use small macro wrapper to pass

-- 
2.23.0.746.g72fc0fc0b9

Junio C Hamano· Oct 11, 2019, 05:59 UTC · re: Denton Liu · lore

Re: [PATCH] pthread.h: manually align parameter lists

Denton Liu <liu.denton@gmail.com> writes:

Show 25 quoted lines

> In previous patches, extern was mechanically removed from function
> declarations without care to formatting, causing parameter lists to be
> misaligned. Manually format changed sections such that the parameter
> lists are realigned.
>
> Viewing this patch with 'git diff -w' should produce no output.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
> I missed a step in 'dl/compat-cleanup'. This patch can be applied on the
> tip of that branch.
>
>  compat/win32/pthread.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
> index f1cfe73de9..737983d00b 100644
> --- a/compat/win32/pthread.h
> +++ b/compat/win32/pthread.h
> @@ -51,7 +51,7 @@ typedef struct {
>  } pthread_t;
>  
>  int pthread_create(pthread_t *thread, const void *unused,
> -			  void *(*start_routine)(void*), void *arg);
> +		   void *(*start_routine)(void*), void *arg);

Yup, I missed that too.  Thanks for a clean-up.

>  
>  /*
>   * To avoid the need of copying a struct, we use small macro wrapper to pass