From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 11 Oct 2019 05:59:55 GMT
Subject: Re: [PATCH] pthread.h: manually align parameter lists
Message-ID: <xmqqimovhles.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <b3d6dfe44a76c4f3bf00eb901c1844b12300c66e.1570736137.git.liu.denton@gmail.com>

Denton Liu <liu.denton@gmail.com> writes:

> In previous patches, extern was mechanically removed from function
> declarations without care to formatting, causing parameter lists to be
> misaligned. Manually format changed sections such that the parameter
> lists are realigned.
>
> Viewing this patch with 'git diff -w' should produce no output.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
> I missed a step in 'dl/compat-cleanup'. This patch can be applied on the
> tip of that branch.
>
>  compat/win32/pthread.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
> index f1cfe73de9..737983d00b 100644
> --- a/compat/win32/pthread.h
> +++ b/compat/win32/pthread.h
> @@ -51,7 +51,7 @@ typedef struct {
>  } pthread_t;
>  
>  int pthread_create(pthread_t *thread, const void *unused,
> -			  void *(*start_routine)(void*), void *arg);
> +		   void *(*start_routine)(void*), void *arg);

Yup, I missed that too.  Thanks for a clean-up.

>  
>  /*
>   * To avoid the need of copying a struct, we use small macro wrapper to pass