Re: [PATCH 1/1] maintenance: fix a SEGFAULT when no repository

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 24, 2020, 21:48 UTC
Message-ID: <xmqqim9uifz8.fsf@gitster.c.googlers.com>
In-Reply-To: <1bfd84da-5b74-be10-fc2c-dee80111ee2d@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 5 quoted lines

> The reason to use RUN_SETUP_GENTLY was probably due to some thought
> of modifying the background maintenance schedule without being in a
> Git repository. However, we currently run the [un]register logic
> inside of the stop|start subcommands, so a GIT_DIR is required there,
> too.

Meaning all the operations we currently support requires to be done in a repository? If so, that may be acceptable.

When a new operation that does not require to be in a repository is added, or when an existing operation is updated not to require to be in a repository, reverting the change and then checking in the implementation of each operation if we are in a repository instead should be easy enough---it pretty much should amount to Rafael's patch, right?

But then, being prepared for that future already is also OK, so I can go either way. Please figure it out between you ;-)

Thanks, all.