Re: [PATCH 1/1] maintenance: fix a SEGFAULT when no repository

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Nov 24, 2020, 19:14 UTC
Message-ID: <20201124191407.GC8396@szeder.dev>
In-Reply-To: <CAPig+cQ-iWVz2Q1PtvbV0hk_HHRFqAFjxAF2DZ6doh2RxpZJhw@mail.gmail.com>

On Tue, Nov 24, 2020 at 12:24:57PM -0500, Eric Sunshine wrote:

Show 10 quoted lines

> On Tue, Nov 24, 2020 at 11:45 AM Rafael Silva
> <rafaeloliveira.cs@gmail.com> wrote:
> > diff --git a/t/t7900-maintenance.sh b/t/t7900-maintenance.sh
> > @@ -441,4 +441,9 @@ test_expect_success 'register preserves existing strategy' '
> > +test_expect_success 'run and start command fails when no git repository' '
> > +       test_must_fail git -C /tmp/ maintenance run &&
> > +       test_must_fail git -C /tmp/ maintenance start
> > +'
> 
> I wouldn't feel comfortable relying upon existence of /tmp/.

Indeed.

Show 7 quoted lines

> It might
> be sufficient to do this instead:
> 
>     mv .git save.git &&
>     test_when_finished "mv save.git .git" &&
>     test_must_fail git maintenance run &&
>     test_must_fail git maintenance start

Our test library contains the 'nongit' helper function exactly for this purpose:

    nongit test_must_fail git maintenance run &&
    nongit test_must_fail git maintenance start