Re: [PATCH v2 1/1] maintenance: fix SEGFAULT when no repository

From: Rafael Silva <rafaeloliveira.cs@gmail.com>
Date: Dec 9, 2020, 09:29 UTC
Message-ID: <gohp6kmtynuzdy.fsf@gmail.com>
In-Reply-To: <20201208201256.GK36751@google.com>

Josh Steadmon writes:

Show 22 quoted lines

> On 2020.11.26 20:41, Rafael Silva wrote:
>> diff --git a/t/t7900-maintenance.sh b/t/t7900-maintenance.sh
>> index d9e68bb2bf..ae5c29b0ff 100755
>> --- a/t/t7900-maintenance.sh
>> +++ b/t/t7900-maintenance.sh
>> @@ -441,4 +441,12 @@ test_expect_success 'register preserves existing strategy' '
>>  	test_config maintenance.strategy incremental
>>  '
>>  
>> +test_execpt_success 'fails when running outside of a repository' '
>> +	nongit test_must_fail git maintenance run &&
>> +	nongit test_must_fail git maintenance stop &&
>> +	nongit test_must_fail git maintenance start &&
>> +	nongit test_must_fail git maintenance register &&
>> +	nongit test_must_fail git maintenance unregister
>> +'
>> +
>>  test_done
>
> Caught a typo here, sending this as a squash patch since it's already in
> next:
>

Ufff. For some reason I completely missed the test error message when working on the v2.

Thank you Josh, for the catch and quick patch.

Apologize guys for such mistake.

-- 
Thanks, Rafael