Re: [PATCH v4 01/12] pkt-line: eliminate the need for static buffer in packet_write_gently()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 4, 2021, 20:26 UTC
- Message-ID
- <xmqqim66ekck.fsf@gitster.c.googlers.com>
- In-Reply-To
- <85cd4d20-f68d-ef1d-c95b-f34f61f906b1@jeffhostetler.com>
Jeff Hostetler <git@jeffhostetler.com> writes:
Show 15 quoted lines
> On 3/3/21 2:38 PM, Junio C Hamano wrote: > >> I agree with both of you that the code is unnice in its stack usage >> and we want fix with malloc(), or something like that, but sorry, I >> think I merged this round by mistake to 'next'. >> As we won't be merging the topic to the upcoming release anyway, I >> am willing to revert the merge to 'next' and requeue an updated one, >> when it appears (I am also OK to see an incremental update, "oops, >> no, we realize we don't want to have it on the stack" fix-up, if >> this is the only glitch in the series that need to be fixed). > > I'm preparing a follow-on patch series to address Peff's comments > from Friday/Monday and yours from yesterday. I thought I'd send > it as a set of new changes to sit on top of what we have in "next" > if that would make things easier for you.
Yeah, that is OK, too. Sorry for the mistake of merging it too early.