Re: [PATCH v2 09/14] simple-ipc: add t/helper/test-simple-ipc and t0052

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Feb 5, 2021, 19:38 UTC
Message-ID: <20210205193847.GG2091@szeder.dev>
In-Reply-To: <f0bebf1cdb31f94cb111df100b3bcb5e2d93a91e.1612208747.git.gitgitgadget@gmail.com>

On Mon, Feb 01, 2021 at 07:45:42PM +0000, Jeff Hostetler via GitGitGadget wrote:

> Create unit tests for "simple-ipc".  These are currently only enabled
> on Windows.

> diff --git a/t/t0052-simple-ipc.sh b/t/t0052-simple-ipc.sh

Show 5 quoted lines

> +test_expect_success '`quit` works' '
> +	test-tool simple-ipc send quit &&
> +	test_must_fail test-tool simple-ipc is-active &&
> +	test_must_fail test-tool simple-ipc send ping
> +'

This test is flaky as well, and it did actually fail in CI:

  expecting success of 0052.9 '`quit` works': 
  	test-tool simple-ipc send quit &&
  	test_must_fail test-tool simple-ipc is-active &&
  	test_must_fail test-tool simple-ipc send ping
  
  +test-tool simple-ipc send quit
  +test_must_fail test-tool simple-ipc is-active
  test_must_fail: command succeeded: test-tool simple-ipc is-active
  error: last command exited with $?=1
  not ok 9 - `quit` works

Show 5 quoted lines

> +
> +test_done
> -- 
> gitgitgadget
>