Re: [PATCH v2 06/14] pkt-line: accept additional options in read_packetized_to_strbuf()
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Feb 11, 2021, 01:52 UTC
- Message-ID
- <YCSN260gqNV+DyTI@nand.local>
- In-Reply-To
- <6a389a3533512acedfa1769c64296c1e19b16221.1612208747.git.gitgitgadget@gmail.com>
On Mon, Feb 01, 2021 at 07:45:39PM +0000, Johannes Schindelin via GitGitGadget wrote:
Show 19 quoted lines
> diff --git a/pkt-line.c b/pkt-line.c
> index 528493bca21..f090fc56eef 100644
> --- a/pkt-line.c
> +++ b/pkt-line.c
> @@ -461,7 +461,7 @@ char *packet_read_line_buf(char **src, size_t *src_len, int *dst_len)
> return packet_read_line_generic(-1, src, src_len, dst_len);
> }
>
> -ssize_t read_packetized_to_strbuf(int fd_in, struct strbuf *sb_out)
> +ssize_t read_packetized_to_strbuf(int fd_in, struct strbuf *sb_out, int options)
> {
> int packet_len;
>
> @@ -477,7 +477,7 @@ ssize_t read_packetized_to_strbuf(int fd_in, struct strbuf *sb_out)
> * that there is already room for the extra byte.
> */
> sb_out->buf + sb_out->len, LARGE_PACKET_DATA_MAX+1,
> - PACKET_READ_GENTLE_ON_EOF);
> + options | PACKET_READ_GENTLE_ON_EOF);This feels a little magical to me. Since read_packetized_to_strbuf only has the one caller you mention, why not have the caller pass all of the options (including PACKET_READ_GENTLE_ON_EOF)?
Show 14 quoted lines
> if (packet_len <= 0) > break; > sb_out->len += packet_len; > diff --git a/pkt-line.h b/pkt-line.h > index 7f31c892165..150319a6f00 100644 > --- a/pkt-line.h > +++ b/pkt-line.h > @@ -145,8 +145,12 @@ char *packet_read_line_buf(char **src_buf, size_t *src_len, int *size); > > /* > * Reads a stream of variable sized packets until a flush packet is detected. > + * > + * The options are augmented by PACKET_READ_GENTLE_ON_EOF and passed to > + * packet_read.
Obviously this comment will need updating if you take my suggestion.
Thanks, Taylor