Re: [PATCH 3/3] diff: correct warning message when renameLimit exceeded
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 14, 2021, 01:10 UTC
- Message-ID
- <xmqqim1dzomt.fsf@gitster.g>
- In-Reply-To
- <CABPp-BHdAZYPf0QPOTiekU914u6pNxUSRQEmdN0xOLGv5hdkzA@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
> The exhaustiveness of the quadratic portion comes from comparing each > file to more other files, not in using a different type of comparison.
Exactly. By culling potential matches early with heuristics, we make a trade-off of risking false-negatives but save a lot of cycles while trying to find "renames with modifications (which is what we called 'inexact rename')", and my comment equated fewer false-negatives with more precision.