Re: [PATCH v3 0/4] Rename/copy limits -- docs, warnings, and new defaults

From: Derrick Stolee <stolee@gmail.com>
Date: Jul 15, 2021, 13:36 UTC
Message-ID: <9ae3987e-2d28-a308-3d12-28ec3c8e996f@gmail.com>
In-Reply-To: <pull.1044.v3.git.git.1626309924.gitgitgadget@gmail.com>

On 7/14/2021 8:45 PM, Elijah Newren via GitGitGadget wrote:

Show 9 quoted lines

> Fix a few small issues with documentation and warnings around the limits for
> the quadratic portion of rename (&copy) detection, and bump the default
> limits.
> 
> Discussion on bumping the limits can be found at [1]. Although it appears we
> generally agree we could switch to an unlimited setting for
> merge.renameLimit, that would require some changes to progress bars to
> notify users how to take action once things start taking a while. So, for
> now, just bump the limits.

I briefly read through the responses to v2, and it looks like you updated your v3 appropriately. I think the changes since v2 also satisfy my comments on v1. This version LGTM.

Thanks, -Stolee