Re: [PATCH v3] name-rev: use generation numbers if available

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 10, 2022, 00:33 UTC
Message-ID: <xmqqilsmir41.fsf@gitster.g>
In-Reply-To: <20220310000550.2368737-1-jacob.e.keller@intel.com>

Jacob Keller <jacob.e.keller@intel.com> writes:

Show 16 quoted lines

> +# A-B-C-D-E-main
> +#
> +# Where C has a non-monotonically increasing commit timestamp w.r.t. other
> +# commits
> +test_expect_success 'non-monotonic commit dates setup' '
> +	UNIX_EPOCH_ZERO="@0 +0000" &&
> +	git init non-monotonic &&
> +	test_commit -C non-monotonic A &&
> +	test_commit -C non-monotonic --no-tag B &&
> +	test_commit -C non-monotonic --no-tag --date "$UNIX_EPOCH_ZERO" C &&
> +	test_commit -C non-monotonic D &&
> +	test_commit -C non-monotonic E
> +'
> +
> +test_expect_success 'name-rev with commitGraph handles non-monotonic timestamps' '
> +	test_config -C non-monotonic core.commitGraph false &&

Don't you mean "true" here?

Show 9 quoted lines

> +	(
> +		cd non-monotonic &&
> +
> +		echo "main~3 tags/D~2" >expect &&
> +		git name-rev --tags main~3 >actual &&
> +
> +		test_cmp expect actual
> +	)
> +'

Other than that there wasn't anything unexpected in this iteration.

Thanks.