RE: [PATCH v3] name-rev: use generation numbers if available

> -----Original Message-----
> From: Junio C Hamano <gitster@pobox.com>
> Sent: Wednesday, March 09, 2022 4:33 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: git@vger.kernel.org; Jacob Keller <jacob.keller@gmail.com>
> Subject: Re: [PATCH v3] name-rev: use generation numbers if available
> 
> Jacob Keller <jacob.e.keller@intel.com> writes:
> 
> > +# A-B-C-D-E-main
> > +#
> > +# Where C has a non-monotonically increasing commit timestamp w.r.t. other
> > +# commits
> > +test_expect_success 'non-monotonic commit dates setup' '
> > +	UNIX_EPOCH_ZERO="@0 +0000" &&
> > +	git init non-monotonic &&
> > +	test_commit -C non-monotonic A &&
> > +	test_commit -C non-monotonic --no-tag B &&
> > +	test_commit -C non-monotonic --no-tag --date "$UNIX_EPOCH_ZERO" C
> &&
> > +	test_commit -C non-monotonic D &&
> > +	test_commit -C non-monotonic E
> > +'
> > +
> > +test_expect_success 'name-rev with commitGraph handles non-monotonic
> timestamps' '
> > +	test_config -C non-monotonic core.commitGraph false &&
> 
> Don't you mean "true" here?
> 

> > +	(
> > +		cd non-monotonic &&
> > +
> > +		echo "main~3 tags/D~2" >expect &&
> > +		git name-rev --tags main~3 >actual &&
> > +
> > +		test_cmp expect actual
> > +	)
> > +'
> 
> Other than that there wasn't anything unexpected in this iteration.
> 
> Thanks.