Re: [PATCH v3] name-rev: use generation numbers if available
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 10, 2022, 01:32 UTC
- Message-ID
- <xmqqa6dyiocy.fsf@gitster.g>
- In-Reply-To
- <xmqqilsmir41.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 14 quoted lines
>> +test_expect_success 'name-rev with commitGraph handles non-monotonic timestamps' ' >> + test_config -C non-monotonic core.commitGraph false && > > Don't you mean "true" here? > >> + ( >> + cd non-monotonic && >> + >> + echo "main~3 tags/D~2" >expect && >> + git name-rev --tags main~3 >actual && >> + >> + test_cmp expect actual >> + ) >> +'
And I am not sure if there is anybody _writing_ the graph file in the first place, so perhaps squash this in?
t/t6120-describe.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh index 0b18f73779..9a35e783a7 100755 --- a/t/t6120-describe.sh +++ b/t/t6120-describe.sh @@ -503,10 +503,12 @@ test_expect_success 'non-monotonic commit dates setup' ' ' test_expect_success 'name-rev with commitGraph handles non-monotonic timestamps' ' - test_config -C non-monotonic core.commitGraph false && + test_config -C non-monotonic core.commitGraph true && ( cd non-monotonic && + git commit-graph write --reachable && + echo "main~3 tags/D~2" >expect && git name-rev --tags main~3 >actual &&
-- 2.35.1-744-g1f8f0331bc