Re: [PATCH v3 3/5] archive-tar: add internal gzip implementation

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2022, 19:10 UTC
Message-ID: <xmqqilp45qhq.fsf@gitster.g>
In-Reply-To: <75e76d0f-2ab0-ebf7-4a4e-7a6e0fca0b1a@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 8 quoted lines

> @@ -148,7 +148,8 @@ tar.<format>.command::
>  	format is given.
>  +
>  The "tar.gz" and "tgz" formats are defined automatically and default to
> -`gzip -cn`. You may override them with custom commands.
> +`gzip -cn`. You may override them with custom commands. An internal gzip
> +implementation can be used by specifying the value `git archive gzip`.
>

The new sentence didn't click and I was lost in figuring out what is set to which value and where, before looking at a test the patch adds.

I think it is not entirely a fault of this patch, but the badness is already in the original. I wouldn't have been as confused if it were like so:

    The "tar.gz" and "tgz" formats are defined automatically to use
    `gzip -cn` as the command by default.  An internal gzip
    implementation can be used by specifying the value `git archive
    gzip` for these two formats.

for example.

Thanks.