Re: [PATCH 1/2] archive: replace write_or_die() calls with write_block_or_die()

From: Rohit Ashiwal <rohit.ashiwal265@gmail.com>
Date: Apr 14, 2019, 04:34 UTC
Message-ID: <20190414043409.9547-1-rohit.ashiwal265@gmail.com>
In-Reply-To: <20190413013451.GB2040@sigill.intra.peff.net>

Hey Peff!

On 2019-04-13  1:34 UTC Jeff King <peff@peff.net> wrote:

Show 5 quoted lines

> What is gzwrite()?
> [...]
> I think it would be less confusing if this just factored out
> write_block_or_die(), which starts as a thin wrapper and then grows the
> gzip parts in the next patch.

You are right, it might appear to someone as a bit confusing, but I feel like, this is the right commit to put it.

> Is it OK for us to ask about the truthiness of this opaque type? That
> works if it's really a pointer behind the scenes, but it seems like it
> would be equally OK for zlib to declare it as a struct.

It would be perfectly sane on zlib's part to make gzFile a struct, and if so happens, I'll be there to refactor the code.

Regards Rohit