Re: [PATCH 2/2] archive: avoid spawning `gzip`

From: René Scharfe <l.s.r@web.de>
Date: Apr 13, 2019, 22:01 UTC
Message-ID: <8ef2164c-1d44-33bf-ea8a-49fa0b5c8abf@web.de>
In-Reply-To: <20190413015102.GC2040@sigill.intra.peff.net>

Am 13.04.2019 um 03:51 schrieb Jeff King:

Show 9 quoted lines

> On Fri, Apr 12, 2019 at 04:04:40PM -0700, Rohit Ashiwal via GitGitGadget wrote:
>
>> From: Rohit Ashiwal <rohit.ashiwal265@gmail.com>
>>
>> As we already link to the zlib library, we can perform the compression
>> without even requiring gzip on the host machine.
>
> Very cool. It's nice to drop a dependency, and this should be a bit more
> efficient, too.

Getting rid of dependencies is good, and using zlib is the obvious way to generate .tgz files. Last time I tried something like that, a separate gzip process was faster, though -- at least on Linux [1]. How does this one fare?

Doing compression in its own thread may be a good idea.

René

[1] http://public-inbox.org/git/4AAAC8CE.8020302@lsrfire.ath.cx/