Re: [PATCH 2/5] rebase: store orig_head as a commit
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 15, 2022, 16:58 UTC
- Message-ID
- <xmqqilmt30me.fsf@gitster.g>
- In-Reply-To
- <cced4a48360b4e4a8ce791e9404ac6b37bae4eba.1660576283.git.gitgitgadget@gmail.com>
"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 7 quoted lines
> From: Phillip Wood <phillip.wood@dunelm.org.uk> > > Using a struct commit rather than a struct oid to hold orig_head means > that we error out straight away if branch being rebased does not point > to a commit. It also simplifies the code than handles finding the > merge base and fork point as it not longer has to convert from an oid > to a commit.
As lookup_commit_reference_by_name() eventually calls into deref_tag(), a command like
git rebase -i maint $(git rev-parse v2.37.2)
would presumably still work, which is good.