git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] branch, for-each-ref, tag: add option to omit empty lines

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 7, 2023, 18:48 UTC
Message-ID
<xmqqile7jzq2.fsf@gitster.g>
In-Reply-To
<20230407175316.6404-1-oystwa@gmail.com>
Øystein Walle <oystwa@gmail.com> writes:
Show 11 quoted lines
> If the given format string expands to the empty string a newline is
> still printed it. This makes using the output linewise more tedious. For
> example, git update-ref --stdin does not accept empty lines.
>
> Add options to branch and for-each-ref to not print these empty lines.
> The default behavior remains the same.
>
> Signed-off-by: Øystein Walle <oystwa@gmail.com>
> ---
> Dang, you're right. But yes, it was a near-identical patch to
> builtin/tag.c. Along with a test, of course.

There are small nits like "do not explicitly initialize statics to 0", which may not be big enough to warrant a reroll. Other than that, looking good.

Thanks, will replace.
Previous: Øystein WalleNext: Andrei Rybak
Message 13 of 30 in “branch, for-each-ref: add option to omit empty lines”
  1. 0/2 branch, for-each-ref: add option to omit empty linesØystein Walle, Mar 30, 2023
  2. 1/2 ref-filter: remove unused ref_format memberØystein Walle, Mar 30, 2023
  3. Junio C HamanoMar 30, 2023
  4. Junio C HamanoMar 30, 2023
  5. Øystein WalleMar 31, 2023
  6. ZheNing HuMar 31, 2023
  7. Junio C HamanoMar 31, 2023
  8. 0/2 branch, for-each-ref: add option to omit empty linesØystein Walle, Apr 6, 2023
  9. 1/2 ref-filter: remove unused ref_format memberØystein Walle, Apr 6, 2023
  10. 2/2 branch, for-each-ref: add option to omit empty linesØystein Walle, Apr 6, 2023
  11. Junio C HamanoApr 6, 2023
  12. branch, for-each-ref, tag: add option to omit empty linesØystein Walle, Apr 7, 2023
  13. Junio C HamanoApr 7, 2023
  14. Andrei RybakApr 12, 2023
  15. Øystein WalleApr 13, 2023
  16. Junio C HamanoApr 13, 2023
  17. 2/2 branch, for-each-ref: add option to omit empty linesØystein Walle, Mar 30, 2023
  18. Junio C HamanoMar 30, 2023
  19. Jeff KingMar 30, 2023
  20. Junio C HamanoMar 30, 2023
  21. Øystein WalleMar 31, 2023
  22. Junio C HamanoMar 31, 2023
  23. Junio C HamanoMar 30, 2023
  24. Phillip WoodMar 31, 2023
  25. Junio C HamanoMar 31, 2023
  26. Øystein WalleApr 6, 2023
  27. Jeff KingApr 6, 2023
  28. Junio C HamanoApr 6, 2023
  29. Jeff KingApr 10, 2023
  30. Junio C HamanoApr 6, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.