Re: [PATCH v3] branch, for-each-ref, tag: add option to omit empty lines
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 7, 2023, 18:48 UTC
- Message-ID
- <xmqqile7jzq2.fsf@gitster.g>
- In-Reply-To
- <20230407175316.6404-1-oystwa@gmail.com>
Øystein Walle <oystwa@gmail.com> writes:
Show 11 quoted lines
> If the given format string expands to the empty string a newline is > still printed it. This makes using the output linewise more tedious. For > example, git update-ref --stdin does not accept empty lines. > > Add options to branch and for-each-ref to not print these empty lines. > The default behavior remains the same. > > Signed-off-by: Øystein Walle <oystwa@gmail.com> > --- > Dang, you're right. But yes, it was a near-identical patch to > builtin/tag.c. Along with a test, of course.
There are small nits like "do not explicitly initialize statics to 0", which may not be big enough to warrant a reroll. Other than that, looking good.
Thanks, will replace.