git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/2] ref-filter: remove unused ref_format member

From
Øystein Walle <oystwa@gmail.com>
Date
Apr 6, 2023, 17:08 UTC
Message-ID
<20230406170837.10060-2-oystwa@gmail.com>
In-Reply-To
<20230406170837.10060-1-oystwa@gmail.com>

use_rest was added in b9dee075eb (ref-filter: add %(rest) atom, 2021-07-26) but was never used. A follow-up patch series[1] that used this member was submitted, but ultimately the development was abandonded due to performance problems.

[1]: https://lore.kernel.org/git/9c5fddf6885875ccd3ce3f047bb938c77d9bbca2.1628842990.git.gitgitgadget@gmail.com/
Signed-off-by: Øystein Walle <oystwa@gmail.com>
---
 ref-filter.h | 1 -
 ref-filter.c | 1 -
 2 files changed, 2 deletions(-)
diff --git a/ref-filter.h b/ref-filter.h
index daa6d02017..e3eea5e3ad 100644
--- a/ref-filter.h
+++ b/ref-filter.h
@@ -75,7 +75,6 @@ struct ref_format {
 	const char *format;
 	const char *rest;
 	int quote_style;
-	int use_rest;
 	int use_color;
 
 	/* Internal state to ref-filter */
diff --git a/ref-filter.c b/ref-filter.c
index ed802778da..20e0a72f24 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -596,7 +596,6 @@ static int rest_atom_parser(struct ref_format *format,
 {
 	if (arg)
 		return err_no_arg(err, "rest");
-	format->use_rest = 1;
 	return 0;
 }
 
-- 
2.20.1
Previous: Øystein WalleNext: Øystein Walle
Message 9 of 30 in “branch, for-each-ref: add option to omit empty lines”
  1. 0/2 branch, for-each-ref: add option to omit empty linesØystein Walle, Mar 30, 2023
  2. 1/2 ref-filter: remove unused ref_format memberØystein Walle, Mar 30, 2023
  3. Junio C HamanoMar 30, 2023
  4. Junio C HamanoMar 30, 2023
  5. Øystein WalleMar 31, 2023
  6. ZheNing HuMar 31, 2023
  7. Junio C HamanoMar 31, 2023
  8. 0/2 branch, for-each-ref: add option to omit empty linesØystein Walle, Apr 6, 2023
  9. 1/2 ref-filter: remove unused ref_format memberØystein Walle, Apr 6, 2023
  10. 2/2 branch, for-each-ref: add option to omit empty linesØystein Walle, Apr 6, 2023
  11. Junio C HamanoApr 6, 2023
  12. branch, for-each-ref, tag: add option to omit empty linesØystein Walle, Apr 7, 2023
  13. Junio C HamanoApr 7, 2023
  14. Andrei RybakApr 12, 2023
  15. Øystein WalleApr 13, 2023
  16. Junio C HamanoApr 13, 2023
  17. 2/2 branch, for-each-ref: add option to omit empty linesØystein Walle, Mar 30, 2023
  18. Junio C HamanoMar 30, 2023
  19. Jeff KingMar 30, 2023
  20. Junio C HamanoMar 30, 2023
  21. Øystein WalleMar 31, 2023
  22. Junio C HamanoMar 31, 2023
  23. Junio C HamanoMar 30, 2023
  24. Phillip WoodMar 31, 2023
  25. Junio C HamanoMar 31, 2023
  26. Øystein WalleApr 6, 2023
  27. Jeff KingApr 6, 2023
  28. Junio C HamanoApr 6, 2023
  29. Jeff KingApr 10, 2023
  30. Junio C HamanoApr 6, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.