Re: [PATCH v3] branch, for-each-ref, tag: add option to omit empty lines
A couple of drive-by nitpicks about the commit message:
On 07/04/2023 19:53, Øystein Walle wrote:
> Subject: [PATCH v3] branch, for-each-ref, tag: add option to omit empty lines
>
> If the given format string expands to the empty string a newline is
> still printed it. This makes using the output linewise more tedious. For
It seems that a word is missing in the first sentence. Perhaps,
s/printed it/printed for it/
?
> example, git update-ref --stdin does not accept empty lines.
>
> Add options to branch and for-each-ref to not print these empty lines.
"git tag" is mentioned in the subject line, but not here.
Show 21 quoted lines
> The default behavior remains the same.
>
> Signed-off-by: Øystein Walle <oystwa@gmail.com>
> ---
> Dang, you're right. But yes, it was a near-identical patch to
> builtin/tag.c. Along with a test, of course.
>
> I see you already applied the first of these patches so in this
> iteration there's only one.
>
> Documentation/git-branch.txt | 4 ++++
> Documentation/git-for-each-ref.txt | 4 ++++
> Documentation/git-tag.txt | 4 ++++
> builtin/branch.c | 6 +++++-
> builtin/for-each-ref.c | 7 +++++--
> builtin/tag.c | 6 +++++-
> t/t3203-branch-output.sh | 24 ++++++++++++++++++++++++
> t/t6300-for-each-ref.sh | 8 ++++++++
> t/t7004-tag.sh | 16 ++++++++++++++++
> 9 files changed, 75 insertions(+), 4 deletions(-)
>
Andrei Rybak <rybak.a.v@gmail.com>