Re: [PATCH] send-email: export patch counters in validate environment

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 11, 2023, 19:14 UTC
Message-ID: <xmqqile29qpw.fsf@gitster.g>
In-Reply-To: <CRU3FHOZIRVM.3N8I4FAZ2RGO5@ringo>

"Robin Jarry" <robin@jarry.cc> writes:

> It is probably best to let git-send-email out of the picture. Since
> nothing prevents from sending multiple patch series at once, it may not
> be possible to determine the proper ordering of all these files. A dumb
> 1-based counter will be perfectly suitable.

As long as the design decision is clearly documented, I am more than fine to make it the user's problem ;-) It is a better design between the two, as the user knows better what their payload is.

> I can run the loop twice to determine the count of non-FIFOs and adjust
> GIT_SENDEMAIL_FILE_TOTAL accordingly.

It sounds like a reasonable way out.

Thanks.