Re: [PATCH v2] send-email: export patch counters in validate environment

From: Robin Jarry <robin@jarry.cc>
Date: Apr 12, 2023, 20:39 UTC
Message-ID: <CRV2G5WD329G.3ATH750WRKPIF@ringo>
In-Reply-To: <xmqq7cug96qv.fsf@gitster.g>

Junio C Hamano, Apr 12, 2023 at 22:37:

> You are the user who just ran format-patch to prepare sending out
> the patches, and you are checking your patches.  Wouldn't you have
> the blobs already anyways?

But these will be new blobs since we are applying the patches from files into another detached branch.

Show 19 quoted lines

> I'd rather not to see anybody go in that direction.  "set -e" is a
> poor substitute for a properly designed error handling.  Between
>
> 	set -e
> 	command A
> 	command B
> 	command C
>
> and
>
> 	command A &&
> 	command B &&
> 	command C || die message
>
> the former can only say "command B" failed because command B was run
> under some condition that it did not like, but that is too low level
> an error that is close to the implementation.  As opposed to the
> latter that can talk about what it _means_ that any one of these
> three commands did not succeed in the end-user's terms.

Ok.