Re: [PATCH] send-email: export patch counters in validate environment

From: Robin Jarry <robin@jarry.cc>
Date: Apr 11, 2023, 16:47 UTC
Message-ID: <CRU2VKKMECFZ.2GSICU4EKKBDR@ringo>
In-Reply-To: <79a7c59f-6644-1dad-3b85-fe0ca8beb968@gmail.com>

Phillip Wood, Apr 11, 2023 at 15:23:

> This is certainly less intrusive, if it does what you need and is 
> efficient enough for your needs then I'd be inclined to go with this 
> approach.

Yes, that is perfectly suitable to validate series. The missing pieces of information (e.g. the place where all patches are spooled) can be either hard coded or stored in git config entries.

Show 13 quoted lines

> >   	foreach my $f (@files) {
> >   		unless (-p $f) {
> > +			$ENV{GIT_SENDEMAIL_PATCH_COUNTER} = "$num";
> > +			$ENV{GIT_SENDEMAIL_PATCH_TOTAL} = "$num_patches";
>
> We only need to set this once outside the loop
>
> >   			validate_patch($f, $target_xfer_encoding);
> > +			delete $ENV{GIT_SENDEMAIL_PATCH_COUNTER};
> > +			delete $ENV{GIT_SENDEMAIL_PATCH_TOTAL};
>
> Do we really need to clear these? Certainly not in each iteration of the 
> loop I would think.

I wanted to keep everything collocated. The time spent setting/unsetting these variables is completely negligible. I don't mind making this more streamlined in a v2.

Thanks for the review :)